I would like to ask why my state is not changing when I do an onClick
event. I’ve search a while ago that I need to bind the onClick
function in constructor but still the state is not updating.
Here’s my code:
import React from 'react'; import Grid from 'react-bootstrap/lib/Grid'; import Row from 'react-bootstrap/lib/Row'; import Col from 'react-bootstrap/lib/Col'; import BoardAddModal from 'components/board/BoardAddModal.jsx'; import style from 'styles/boarditem.css'; class BoardAdd extends React.Component { constructor(props) { super(props); this.state = { boardAddModalShow: false }; this.openAddBoardModal = this.openAddBoardModal.bind(this); } openAddBoardModal() { this.setState({ boardAddModalShow: true }); // set boardAddModalShow to true /* After setting a new state it still returns a false value */ console.log(this.state.boardAddModalShow); } render() { return ( <Col lg={3}> <a href="javascript:;" className={style.boardItemAdd} onClick={this.openAddBoardModal}> <div className={[style.boardItemContainer, style.boardItemGray].join(' ')}> Create New Board </div> </a> </Col> ); } } export default BoardAdd
Answers:
Thank you for visiting the Q&A section on Magenaut. Please note that all the answers may not help you solve the issue immediately. So please treat them as advisements. If you found the post helpful (or not), leave a comment & I’ll get back to you as soon as possible.
Method 1
Your state needs some time to mutate, and since console.log(this.state.boardAddModalShow)
executes before the state mutates, you get the previous value as output. So you need to write the console in the callback to the setState
function
openAddBoardModal() { this.setState({ boardAddModalShow: true }, function () { console.log(this.state.boardAddModalShow); }); }
setState
is asynchronous. It means you can’t call it on one line and assume the state has changed on the next.
According to React docs
setState()
does not immediately mutatethis.state
but creates a
pending state transition. Accessingthis.state
after calling this
method can potentially return the existing value. There is no
guarantee of synchronous operation of calls to setState and calls may
be batched for performance gains.
Why would they make setState
async
This is because
setState
alters the state and causes rerendering. This
can be an expensive operation and making it synchronous might leave
the browser unresponsive.Thus the
setState
calls are asynchronous as well as batched for better
UI experience and performance.
Method 2
Fortunately setState()
takes a callback. And this is where we get updated state.
Consider this example.
this.setState({ name: "myname" }, () => {
//callback
console.log(this.state.name) // myname
});
So When callback fires, this.state is the updated state.
You can get mutated/updated
data in callback.
Method 3
Since setSatate is a asynchronous function so you need to console the state as a callback like this.
openAddBoardModal(){ this.setState({ boardAddModalShow: true }, () => { console.log(this.state.boardAddModalShow) }); }
Method 4
For anyone trying to do this with hooks, you need useEffect
.
function App() {
const [x, setX] = useState(5)
const [y, setY] = useState(15)
console.log("Element is rendered:", x, y)
// setting y does not trigger the effect
// the second argument is an array of dependencies
useEffect(() => console.log("re-render because x changed:", x), [x])
function handleXClick() {
console.log("x before setting:", x)
setX(10)
console.log("x in *line* after setting:", x)
}
return <>
<div> x is {x}. </div>
<button onClick={handleXClick}> set x to 10</button>
<div> y is {y}. </div>
<button onClick={() => setY(20)}> set y to 20</button>
</>
}
Output:
Element is rendered: 5 15 re-render because x changed: 5 (press x button) x before setting: 5 x in *line* after setting: 5 Element is rendered: 10 15 re-render because x changed: 10 (press y button) Element is rendered: 10 20
Method 5
setState()
does not always immediately update the component. It may batch or defer the update until later. This makes reading this.state right after calling setState()
a potential pitfall. Instead, use componentDidUpdate
or a setState
callback (setState(updater, callback)
), either of which are guaranteed to fire after the update has been applied. If you need to set the state based on the previous state, read about the updater argument below.
setState()
will always lead to a re-render unless shouldComponentUpdate()
returns false. If mutable objects are being used and conditional rendering logic cannot be implemented in shouldComponentUpdate()
, calling setState()
only when the new state differs from the previous state will avoid unnecessary re-renders.
The first argument is an updater function with the signature:
(state, props) => stateChange
state
is a reference to the component state at the time the change is being applied. It should not be directly mutated. Instead, changes should be represented by building a new object based on the input from state and props. For instance, suppose we wanted to increment a value in state by props.step:
this.setState((state, props) => { return {counter: state.counter + props.step}; });
Method 6
Think of
setState()
as a request rather than an immediate command to
update the component. For better perceived performance, React may
delay it, and then update several components in a single pass. React
does not guarantee that the state changes are applied immediately.
Check this for more information.
In your case you have sent a request to update the state. It takes time for React to respond. If you try to immediately console.log
the state, you will get the old value.
Method 7
This callback is really messy. Just use async await instead:
async openAddBoardModal(){ await this.setState({ boardAddModalShow: true }); console.log(this.state.boardAddModalShow); }
Method 8
If you want to track the state is updating or not then the another way of doing the same thing is
_stateUpdated(){ console.log(this.state. boardAddModalShow); } openAddBoardModal(){ this.setState( {boardAddModalShow: true}, this._stateUpdated.bind(this) ); }
This way you can call the method “_stateUpdated” every time you try to update the state for debugging.
Method 9
Although there are many good answers, if someone lands on this page searching for alternative to useState
for implementing UI components like Navigation drawers which should be opened or closed based on user input, this answer would be helpful.
Though useState
seems handy approach, the state is not set immediately and thus, your website or app looks laggy… And if your page is large enough, react is going to take long time to compute what all should be updated upon state change…
My suggestion is to use refs and directly manipulate the DOM when you want UI to change immediately in response to user action.
Using state for this purspose is really a bad idea in case of react.
Method 10
The above solutions don’t work for useState hooks.
One can use the below code
setState((prevState) => { console.log(boardAddModalShow) // call functions // fetch state using prevState and update return { ...prevState, boardAddModalShow: true } });
Method 11
setState()
is asynchronous. The best way to verify if the state is updating would be in the componentDidUpdate()
and not to put a console.log(this.state.boardAddModalShow)
after this.setState({ boardAddModalShow: true })
.
according to React Docs
Think of setState() as a request rather than an immediate command to update the component. For better perceived performance, React may delay it, and then update several components in a single pass. React does not guarantee that the state changes are applied immediately
Method 12
According to React Docs
React does not guarantee that the state changes are applied immediately.
This makes reading this.state right after calling setState() a potentialpitfall
and can potentially return theexisting
value due toasync
nature .
Instead, usecomponentDidUpdate
or asetState
callback that is executed right after setState operation is successful.Generally we recommend usingcomponentDidUpdate()
for such logic instead.
Example:
import React from "react"; import ReactDOM from "react-dom"; import "./styles.css"; class App extends React.Component { constructor() { super(); this.state = { counter: 1 }; } componentDidUpdate() { console.log("componentDidUpdate fired"); console.log("STATE", this.state); } updateState = () => { this.setState( (state, props) => { return { counter: state.counter + 1 }; }); }; render() { return ( <div className="App"> <h1>Hello CodeSandbox</h1> <h2>Start editing to see some magic happen!</h2> <button onClick={this.updateState}>Update State</button> </div> ); } } const rootElement = document.getElementById("root"); ReactDOM.render(<App />, rootElement);
Method 13
this.setState({ isMonthFee: !this.state.isMonthFee, }, () => { console.log(this.state.isMonthFee); })
Method 14
Yes because setState is an asynchronous function. The best way to set state right after you write set state is by using Object.assign like this:
For eg you want to set a property isValid to true, do it like this
Object.assign(this.state, { isValid: true })
You can access updated state just after writing this line.
Method 15
when i was running the code and checking my output at console it showing the that it is undefined.
After i search around and find something that worked for me.
componentDidUpdate(){}
I added this method in my code after constructor().
check out the life cycle of react native workflow.
https://images.app.goo.gl/BVRAi4ea2P4LchqJ8
All methods was sourced from stackoverflow.com or stackexchange.com, is licensed under cc by-sa 2.5, cc by-sa 3.0 and cc by-sa 4.0