$wpdb->prepare was called incorrectly when inserting multiple records

This works:

$values = array();

foreach (  $_POST as $key => $value ) {
    $values[] = $wpdb->prepare( "(%d,%s,%s)", $post_id, $key, $value );
}

$query = "INSERT INTO {$table} (post_id, meta_key, meta_value) VALUES ";
$query .= implode( ",n", $values );
$wpdb->query( $wpdb->prepare( "$query", $values ) );

But it throws this notice:

PHP Notice: wpdb::prepare was called incorrectly.
The query does not contain the correct number of placeholders (0) for
the number of arguments passed (3).

How can I avoid the Notice?

Answers:

Thank you for visiting the Q&A section on Magenaut. Please note that all the answers may not help you solve the issue immediately. So please treat them as advisements. If you found the post helpful (or not), leave a comment & I’ll get back to you as soon as possible.

Method 1

Well, you don’t need the second $wpdb->prepare() and just do $wpdb->query( $query );. The reason is because the $query does not contain any placeholders just as stated in the notice; only the items in $values contain the placeholders, but you already prepared them in the foreach. Additionally, be sure to run the query() only if the array $values is not empty.


All methods was sourced from stackoverflow.com or stackexchange.com, is licensed under cc by-sa 2.5, cc by-sa 3.0 and cc by-sa 4.0

0 0 votes
Article Rating
Subscribe
Notify of
guest

0 Comments
Oldest
Newest Most Voted
Inline Feedbacks
View all comments
0
Would love your thoughts, please comment.x
()
x