Can you annotate return type when value is instance of cls?

Given a class with a helper method for initialization:

class TrivialClass:
    def __init__(self, str_arg: str):
        self.string_attribute = str_arg

    @classmethod
    def from_int(cls, int_arg: int) -> ?:
        str_arg = str(int_arg)
        return cls(str_arg)

Is it possible to annotate the return type of the from_int method?

I’v tried both cls and TrivialClass but PyCharm flags them as unresolved references which sounds reasonable at that point in time.

Answers:

Thank you for visiting the Q&A section on Magenaut. Please note that all the answers may not help you solve the issue immediately. So please treat them as advisements. If you found the post helpful (or not), leave a comment & I’ll get back to you as soon as possible.

Method 1

Use a generic type to indicate that you’ll be returning an instance of cls:

from typing import Type, TypeVar

T = TypeVar('T', bound='TrivialClass')

class TrivialClass:
    # ...

    @classmethod
    def from_int(cls: Type[T], int_arg: int) -> T:
        # ...
        return cls(...)

Any subclass overriding the class method but then returning an instance of a parent class (TrivialClass or a subclass that is still an ancestor) would be detected as an error, because the factory method is defined as returning an instance of the type of cls.

The bound argument specifies that T has to be a (subclass of) TrivialClass; because the class doesn’t yet exist when you define the generic, you need to use a forward reference (a string with the name).

See the Annotating instance and class methods section of PEP 484.


Note: The first revision of this answer advocated using a forward reference
naming the class itself as the return value, but issue 1212 made it possible to use generics instead, a better solution.

As of Python 3.7, you can avoid having to use forward references in annotations when you start your module with from __future__ import annotations, but creating a TypeVar() object at module level is not an annotation. This is still true even in Python 3.10, which defers all type hint resolution in annotations.

Method 2

From Python 3.7 you can use __future__.annotations:

from __future__ import annotations


class TrivialClass:
    # ...

    @classmethod
    def from_int(cls, int_arg: int) -> TrivialClass:
        # ...
        return cls(...)

Edit: you can’t subclass TrivialClass without overriding the classmethod, but if you don’t require this then I think it’s neater than a forward reference.

Method 3

A simple way to annotate the return type is to use a string as the annotation for the return value of the class method:

# test.py
class TrivialClass:
  def __init__(self, str_arg: str) -> None:
    self.string_attribute = str_arg

  @classmethod
  def from_int(cls, int_arg: int) -> 'TrivialClass':
    str_arg = str(int_arg)
    return cls(str_arg)

This passes mypy 0.560 and no errors from python:

$ mypy test.py --disallow-untyped-defs --disallow-untyped-calls
$ python test.py

Method 4

In Python 3.11 there will be a nicer way to do this using the new Self type:

class TrivialClass:
    def __init__(self, str_arg: str):
        self.string_attribute = str_arg

    @classmethod
    def from_int(cls, int_arg: int) -> Self:
        str_arg = str(int_arg)
        return cls(str_arg)

This is going to work for sub classes as well.

This is described in PEP 673. The example used in the section Use in Classmethod Signatures is exactly equivalent to this question.

I plan to accept this answer once Python 3.11 is released (2022-10-03 as of now).


All methods was sourced from stackoverflow.com or stackexchange.com, is licensed under cc by-sa 2.5, cc by-sa 3.0 and cc by-sa 4.0

0 0 votes
Article Rating
Subscribe
Notify of
guest

0 Comments
Oldest
Newest Most Voted
Inline Feedbacks
View all comments
0
Would love your thoughts, please comment.x
()
x